Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Change HTTP Links to HTTPS in CONTRIBUTING.md #16190

Merged
merged 1 commit into from Nov 15, 2017

Conversation

U8NWXD
Copy link
Contributor

@U8NWXD U8NWXD commented Nov 15, 2017

Description of the Change

Change HTTP links to HTTPS in CONTRIBUTING.md since the linked-to sites support SSL/TLS

Alternate Designs

The alternative would be leaving the links as HTTP ones. This leaves users less secure while having only marginal user experience benefits.

Why Should This Be In Core?

The documentation changed is in Core.

Benefits

Makes user interaction more secure by default.

Possible Drawbacks

Marginal potential for devices not supporting SSL/TLS and marginal performance hits when accessing the links.

Applicable Issues

Similar to issue #16167 and PR #16173

Similar to issue atom#16167 and PR atom#16173
Change links throughout CONTRIBUTING.md to support SSL/TLS by changing URL to `https://`
[ci skip]

Signed-off-by: U8N WXD <cs.temporary@icloud.com>
@50Wliu
Copy link
Contributor

50Wliu commented Nov 15, 2017

Thank you!! 💯

@50Wliu 50Wliu merged commit 192cde8 into atom:master Nov 15, 2017
@U8NWXD U8NWXD deleted the fix-non-ssl-in-contributing branch November 17, 2017 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants